Test data generated on init. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerg84
reviewed
Oct 4, 2019
arangopipe/Dockerfile_Torch_FE
Outdated
| @@ -13,6 +13,7 @@ MAINTAINER Joerg Schad <info@arangodb.com> | |||
| ENV GIT_PYTHON_REFRESH=quiet | |||
| RUN apt-get update | |||
| RUN apt-get install -y python-pip | |||
There was a problem hiding this comment.
Could we combine these installs commands into one? each RUN will generate a new container image layer
There was a problem hiding this comment.
P.S. at best even combine with apt-get update
There was a problem hiding this comment.
@joerg84 , yes, that makes sense. Need to clean up the dockerfiles. There are two old docker files that I need to remove too. Will do these.
There was a problem hiding this comment.
@joerg84 , just made these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test data generation to the startup scripts