Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding is.vivaldi() support #214

Closed
ironmaniiith opened this issue Jun 29, 2016 · 2 comments
Closed

adding is.vivaldi() support #214

ironmaniiith opened this issue Jun 29, 2016 · 2 comments

Comments

@ironmaniiith
Copy link
Collaborator

No description provided.

@ironmaniiith ironmaniiith changed the title adding support for vivaldi browser adding is.vivaldi() support Jun 29, 2016
@jdalton
Copy link
Collaborator

jdalton commented Jun 29, 2016

Dup of #126.

Since vivaldi is built of off chromium + blink I think it's fine that it's detected as is.chrome.
Is.js is not intended to be the be-all-end-all of UA sniffing. There are projects like ua-parser for that.

@jdalton jdalton closed this as completed Jun 29, 2016
@ironmaniiith
Copy link
Collaborator Author

Ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants