typeof NaN is 'number'

[chenxianliang]

// is a given value number?
is.number = function(value) {
    return toString.call(value) === '[object Number]';
};

should be
is.number = function(value) {
return toString.call(value) === '[object Number]' && !isNaN(value);
};
???

[arasatasaygin]

Type of NaN is number.
What others think? Should we return false for NaN on this check?

Thanks @chenxianliang

[cfj]

NaN may technically be a number but I don't think it's in the spirit of the is.number function to return true on NaN.

[limichange]

Type of NaN is number.

[Joshua-F]

I agree with @cfj. NaN stands for Not a Number so I say keep it how it is now it should return false.

[cakuki]

@Joshua-F you do not agree with @cfj. Type of NaN is Number, and right now is.number(NaN) returns true.

👍 for change, is.number(NaN) should return false.

[Joshua-F]

@cakuki, he says he doesn't think it's in the spirit of the is.number function, which I agree with. But to clarify , is.number(NaN) should return false.

[arasatasaygin]

Fixed with #79 from @jonhester
Thanks for all the feedbacks. This check returns false for NaN right now.