Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make is.number return false for NaN #79

Merged
merged 2 commits into from Mar 3, 2015
Merged

make is.number return false for NaN #79

merged 2 commits into from Mar 3, 2015

Conversation

jonhester
Copy link
Contributor

Includes tests

Fix for #72

@arasatasaygin
Copy link
Owner

Hey @jonhester
Thanks for the PR. What do you think about this syntax?

is.number = function(value) {
    return is.not.nan(value) && toString.call(value) === '[object Number]';
};

I try to write one liners, ease to read.

@jonhester
Copy link
Contributor Author

Sounds good. Just updated.

@arasatasaygin arasatasaygin merged commit 101f68d into arasatasaygin:master Mar 3, 2015
@arasatasaygin
Copy link
Owner

Thanks @jonhester
Merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants