More control to show prompt #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- user facing:
- added: +forceShowPrompt: (like showPrompt but no checks, with
option to display rate later button).
- added: +tryToShowPrompt (replaces showPrompt, more explanatory)
- deprecated: +showPrompt
- inner workings:
- added: -showRatingAlert: (option to display rate later button)
- modified: -showRatingAlert (calls showRatingAlert:true)
- added: showPromptWithChecks:displayRateLaterButton:
(used by forceShowPrompt: and tryToShowPrompt)
|
Just skimming the code on github, and this looks good. I still need to pull and test it, but if it works, then I'll merge it in. Thanks for the contribution. |
|
You're welcome. Thanks for your hard work. |
|
Took me awhile, but I finally got around to it. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have a button that the user presses to rate the app, Appirater
provides
+rateApp. But this triggers the review directly, which maynot be ideal for some UIs. The developer may want to display an
intermediary prompt - this prompt can be both informative to the user
and a confirmation step to go ahead and review.
+showPromptdoesn'tfit the bill because it may not open the prompt.
I added
+forceShowPrompt:for this use case. It accepts one argumentto show or hide the rate later button (if triggered by a button, the
developer will probably want to hide the rate later button; but some
may want to keep it in the case of using both
+forceShowPrompt:and the usual automatic Appirater mechanisms).
I also went ahead and created
+tryToShowPrompt. It's the same as+showPrompt, but I felt thatshowPromptneeded to be moreexplanatory, as it may actually not show a prompt, and now that
+forceShowPrompt:exists, the distinction begs to be clearer.+showPromptstill works, I moved it toDeprecated.Here's the full list of changes:
+forceShowPrompt:+tryToShowPrompt+showPrompt-showRatingAlert:(option to display rate later button)-showRatingAlert(callsshowRatingAlert:true)-showPromptWithChecks:displayRateLaterButton:*tryToShowPromptandforceShowPrompt:)