Allow configuration via Appirater.plist, support landscape mode. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Appirater to be configured via optional Appirater.plist file. If omitted, it defaults to the old defaults defined in Appirater.h, except for the iTunes App ID, which defaults to the Info.plist `iTunesAppID` string entry (if omitted it will be 0)
Show only two buttons in rate request dialog: 'Rate' and one of 'Reminde me' and 'No'. Use LandscapeHideCancelCount in Appirater.plist to define how many times to show the 'Remind me' button before showing the 'No' button.
May be turned on via Appirater.plist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added these changes to avoid having to change the code to tailor to a specific usage. Instead, all the configuration options may be specified in an Appirater.plist file (sample included). The plist may be omitted, in which case sensible defaults apply (just as before). Lastly, the AppID may be specified in the Info.plist.
Also added a small change to support landscape orientation (before, the dialog was trimmed if shown in landscape).
Lastly, made debug default to NO. Debug may still be turned on by using an Appirater.plist file.