-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add discriminator helper #47
feat: add discriminator helper #47
Conversation
Allow extension and inheritance of base models with discriminator models.
@jbool24 thanks for this! this is such a good idea. but do you think we can have it in the
|
@arashsheyda I don't have a good reason why not. But I was just trying to keep things separated instead of using internal flags to manipulate what the factory outputs. Your lib, your choice 😃 👍 |
@jbool24 sorry for late reply, I think becuase they share a lot of similarities it's better to do it that way. ps. it's an open source lib so we can talk about it :) it's not my choice only |
@arashsheyda In that case 😄, my two-cents is keeping the two factories discrete from each other because...
I'm open to hear why combining them would be good also. |
@jbool24 well here are my thoughts for having it as
but as you said having it as
🤔 |
As a regular (not so specialized) Mongoose user, I prefer the ideas for a |
@jbool24 thank you! |
Allow extension and inheritance of base models with discriminator models.