Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hasPrevPage behaviour with limit > offset > 0 #144

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Fix hasPrevPage behaviour with limit > offset > 0 #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a07a6eb
Revert "Revert "Merge pull request #133 from chdanielmueller/master""
chdanielmueller Nov 29, 2021
a6c6a9b
Fix tests
chdanielmueller Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,9 @@ function paginate(query, options, callback) {
if (page > 1) {
meta[labelHasPrevPage] = true;
meta[labelPrevPage] = page - 1;
} else if (page == 1 && typeof offset !== 'undefined' && offset !== 0) {
meta[labelHasPrevPage] = true;
meta[labelPrevPage] = 1;
}

// Set next page
Expand Down
32 changes: 30 additions & 2 deletions tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,34 @@ describe('mongoose-paginate', function () {
});
});

it('first page with page and limit, limit > doc.length, offset by one', function () {
var query = {
title: {
$in: [/Book/i],
},
};

var options = {
offset: 1,
limit: 200,
page: 1,
lean: true,
};

return Book.paginate(query, options).then((result) => {
expect(result.docs).to.have.length(99);
expect(result.totalDocs).to.equal(100);
expect(result.limit).to.equal(200);
expect(result.page).to.equal(1);
expect(result.pagingCounter).to.equal(1);
expect(result.hasPrevPage).to.equal(true);
expect(result.hasNextPage).to.equal(false);
expect(result.prevPage).to.equal(1);
expect(result.nextPage).to.equal(null);
expect(result.totalPages).to.equal(1);
});
});

it('first page with page and limit', function () {
var query = {
title: {
Expand Down Expand Up @@ -249,9 +277,9 @@ describe('mongoose-paginate', function () {
expect(result.limit).to.equal(10);
expect(result.page).to.equal(1);
expect(result.pagingCounter).to.equal(1);
expect(result.hasPrevPage).to.equal(false);
expect(result.hasPrevPage).to.equal(true);
expect(result.hasNextPage).to.equal(true);
expect(result.prevPage).to.equal(null);
expect(result.prevPage).to.equal(1);
expect(result.nextPage).to.equal(2);
expect(result.totalPages).to.equal(10);
});
Expand Down