Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sub-document pagination (feats: #174) #175

Merged
merged 4 commits into from
Jun 30, 2022

Conversation

lau1944
Copy link
Contributor

@lau1944 lau1944 commented Jun 26, 2022

Add a new feature for sub-document pagination #174

@aravindnc
Copy link
Owner

@lau1944 Excellent! I will review and merge over this weekend.

@aravindnc aravindnc merged commit d0f24bf into aravindnc:master Jun 30, 2022
@lau1944
Copy link
Contributor Author

lau1944 commented Jun 30, 2022

Cool! Thank you.
If any issue related to this in the future, feel free to mention me, I will look into it.

@aravindnc
Copy link
Owner

aravindnc commented Jul 4, 2022

@lau1944 I've moved your method to a new file.
I've commented out below code from pagination-subdocs.js

  // options = Object.assign(options, {
  //     customLabels: defaultOptions.customLabels,
  // });

Please see if you can get the default options from the index file easily.

@lau1944
Copy link
Contributor Author

lau1944 commented Jul 4, 2022

@aravindnc Looks good to me!
After took a look on the paginate-subdoc method, I only use projection field in the default options object, so I don't think default options is needed in this function.

@lau1944
Copy link
Contributor Author

lau1944 commented Jul 4, 2022

#176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants