Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Setting Joi result back to req #83

Closed
arb opened this issue Aug 28, 2018 · 0 comments
Closed

Change Setting Joi result back to req #83

arb opened this issue Aug 28, 2018 · 0 comments
Labels
breaking-change
Milestone
9.0.0

Comments

@arb
Copy link
Owner

arb commented Aug 28, 2018

Remove conditional and just do Object.defineProperty and set the value there. Make this a breaking change in case it has unintended side effects.
@arb arb added this to the 9.0.0 milestone Aug 31, 2018
arb added a commit that referenced this issue Sep 5, 2018
@arb
Code Cleanup and optimizations
f5661af 
Closes #80
Closes #83

Removed fast-series and just did things using native loops and no callbacks. Saw
about a 1000 ops per second speed improvement. Dropped conditional setting of `req.*` values
and just always use `Object.defineProperty`.
@arb arb mentioned this issue Sep 5, 2018
Merged
@arb arb closed this as completed in #86 Sep 6, 2018
arb added a commit that referenced this issue Sep 6, 2018
@arb
Code Cleanup and optimizations (#86)
8c311d5 
Closes #80
Closes #83

Removed fast-series and just did things using native loops and no callbacks. Saw
about a 1000 ops per second speed improvement. Dropped conditional setting of `req.*` values
and just always use `Object.defineProperty`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
1 participant
@arb