Update build command in GitHub workflows and fix Firebase analytics c…

…heck
arbisyarifudin · Mar 12, 2024 · 99c7691 · 99c7691
1 parent e0ca979
commit 99c7691
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/firebase-hosting-merge.yml b/.github/workflows/firebase-hosting-merge.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - run: npm ci && npm run build
+      - run: npm run build
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
           repoToken: '${{ secrets.GITHUB_TOKEN }}'

diff --git a/.github/workflows/firebase-hosting-pull-request.yml b/.github/workflows/firebase-hosting-pull-request.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - run: npm ci && npm run build
+      - run: npm run build
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:
           repoToken: '${{ secrets.GITHUB_TOKEN }}'

diff --git a/plugins/firebase.js b/plugins/firebase.js
@@ -41,7 +41,7 @@ export default defineNuxtPlugin(nuxtApp => {
 
     if (process.env.NODE_ENV === 'production') {
         const analytics = getAnalytics(app);
-        if (analytics.isSupported()) {
+        if (analytics) {
             console.log('firebase analytics initialized');
         }
     } else {