Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-83256 Solr 7 #561

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

BryanEngler
Copy link

@BryanEngler BryanEngler commented Jul 17, 2018

A few notes/questions:

  • The commit "stucture" is slightly different than the ES6 split. Here the split/clone/merge was done first and then all the changes were applied to the new directory after.

  • Some unit tests would fail when running in a batch with other unit tests. Possibly caused by orphaned documents in the index left from previous tests because re-running the single test on a fresh index would pass.

  • Changing "com.liferay.portal.search.solr.test.unit.started" causes the unit tests to skip in my environment. Not sure why, the name has been changed before 67695ce

  • Should the Bundle-Version be reset to 1.0?

  • Should we remove elevate.xml or document that it must be copied when setting up solr server?

  • Rebasing can be done using the command git rebase upstream/master --preserve-merges and git commit -a at the merge conflict

  • These were the failing tests for Solr 5 (same failures occur for Solr 7):
    Failing solr UNIT tests
    SolrCountTest. testPostFilterWithoutMainQuery
    ModifiedFacetTest. testSearchEngineDateMath
    GroupByTest. testStartAndEnd
    AssetTagNamesFieldQueryBuilderTest. testMultiwordPhrasePrefixes
    DescriptionFieldQueryBuilderTest. testMultiwordPhrasePrefixes
    TitleFieldQueryBuilderTest. testMultiwordPhrasePrefixes
    StringQueryTest. testBooleanOperatorNot
    StringQueryTest. testPrefixOperatorMustNot
    StringQueryTest. testPrefixOperatorMustNotWithBooleanOperatorOr
    Failing solr INTEGRATION tests
    DocumentTest. testFirstNameSearchSortedBySingleLong
    DocumentTest. testLastNameSearchSortedBySingleLong
    DLFileEntrySearchTest. testSearchStatus

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants