forked from liferay/liferay-portal
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-83256 Solr 7 #561
Open
BryanEngler
wants to merge
14
commits into
arboliveira:master
Choose a base branch
from
BryanEngler:LPS-83256-solr_7_2_1
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPS-83256 Solr 7 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
BryanEngler
force-pushed
the
LPS-83256-solr_7_2_1
branch
from
October 17, 2018 20:30
ba5256f
to
30aafce
Compare
arboliveira
force-pushed
the
master
branch
4 times, most recently
from
April 6, 2021 18:39
6f61612
to
751a454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few notes/questions:
The commit "stucture" is slightly different than the ES6 split. Here the split/clone/merge was done first and then all the changes were applied to the new directory after.
Some unit tests would fail when running in a batch with other unit tests. Possibly caused by orphaned documents in the index left from previous tests because re-running the single test on a fresh index would pass.
Changing "com.liferay.portal.search.solr.test.unit.started" causes the unit tests to skip in my environment. Not sure why, the name has been changed before 67695ce
Should the Bundle-Version be reset to 1.0?
Should we remove elevate.xml or document that it must be copied when setting up solr server?
Rebasing can be done using the command
git rebase upstream/master --preserve-merges
andgit commit -a
at the merge conflictThese were the failing tests for Solr 5 (same failures occur for Solr 7):
Failing solr UNIT tests
SolrCountTest. testPostFilterWithoutMainQuery
ModifiedFacetTest. testSearchEngineDateMath
GroupByTest. testStartAndEnd
AssetTagNamesFieldQueryBuilderTest. testMultiwordPhrasePrefixes
DescriptionFieldQueryBuilderTest. testMultiwordPhrasePrefixes
TitleFieldQueryBuilderTest. testMultiwordPhrasePrefixes
StringQueryTest. testBooleanOperatorNot
StringQueryTest. testPrefixOperatorMustNot
StringQueryTest. testPrefixOperatorMustNotWithBooleanOperatorOr
Failing solr INTEGRATION tests
DocumentTest. testFirstNameSearchSortedBySingleLong
DocumentTest. testLastNameSearchSortedBySingleLong
DLFileEntrySearchTest. testSearchStatus