Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up plasticity #1985

Merged
merged 5 commits into from Oct 5, 2022
Merged

Clean up plasticity #1985

merged 5 commits into from Oct 5, 2022

Conversation

thorstenhater
Copy link
Contributor

  1. Fix Python bindings for recipe::update
    • drop the GIL before handing off to C++
    • tighten exception safety
  2. Run plasticity examples with threads; both C++ and Python.
    • C++: Guard against I/O interleaving.
    • Py: Drop spikes from source, prettify reporting.
    • C++: use decor chaining.
  3. Modernise PYBIND11_OVERLOAD -> *RIDE (advised since 2.6) in simulation.
  4. No longer do we initialise connectivity twice.
    • Simplify communicator construction.
    • Fix unit tests that needed to two-phase init communicator.

@thorstenhater
Clean-up plasticity.
e799015 
1. Fix Python bindings for `recipe::update`
   - *drop* the GIL before handing off to C++
   - tighten exception safety
2. Run plasticity examples with threads; both C++ and Python.
   - C++: Guard against I/O interleaving.
   - Py: Drop spikes from source, prettify reporting.
   - C++: use decor chaining.
3. Modernise PYBIND11_OVERLOAD -> *RIDE (advised since 2.6).
4. No longer do we initialise connectivity twice.
   - Simplify communicator construction.
   - Fix unit tests that needed to two-phase init communicator.
@thorstenhater
Part two.
33c9768
@thorstenhater
Eliminate straggler.
3853ff9
@thorstenhater
Stop race on ostream.
f1bea48
@thorstenhater
Stop race on hash table.
901f80e
@thorstenhater thorstenhater merged commit fc85765 into arbor-sim:master Oct 5, 2022
@thorstenhater thorstenhater deleted the py/clean-up-plasticity branch October 5, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

@akuesters akuesters Awaiting requested review from akuesters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thorstenhater @boeschf