AccessValues::_values data member should be private

arborx · Jan 9, 2024 · 4efb1ef · 4efb1ef
1 parent b6080f3
commit 4efb1ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/details/ArborX_AccessTraits.hpp b/src/details/ArborX_AccessTraits.hpp
@@ -194,10 +194,12 @@ class AccessValues
 {
 private:
   using Access = AccessTraits<Values, Tag>;
-
-public:
   Values _values;
 
+public:
+  explicit AccessValues(Values values)
+      : _values(std::move(values))
+  {}
   using memory_space = typename Access::memory_space;
   using value_type = std::decay_t<
       Kokkos::detected_t<AccessTraitsGetArchetypeExpression, Access, Values>>;

diff --git a/src/interpolation/ArborX_InterpMovingLeastSquares.hpp b/src/interpolation/ArborX_InterpMovingLeastSquares.hpp
@@ -159,7 +159,7 @@ class MovingLeastSquares
     // Compute the moving least squares coefficients
     _coeffs = Details::movingLeastSquaresCoefficients<CRBFunc, PolynomialDegree,
                                                       FloatingCalculationType>(
-        space, source_view, target_access._values);
+        space, source_view, target_access);
   }
 
   template <typename ExecutionSpace, typename SourceValues,