Switch top tree in DistributedTree to new API and do some cleanup #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
force-pushed
the
some_distributed_cleanup
branch
from
ce945b7
to
3d62a02
Compare
aprokop
changed the title
aprokop
force-pushed
the
some_distributed_cleanup
branch
from
3d62a02
to
f386c4c
Compare
|
What changed? |
Sorry, I should have made a separate commit. I included few extra headers as the self-containment tests were failing. |
dalg24
reviewed
Jan 4, 2024
| DistributedTree const &tree, Indices &indices, | ||
| Offset &offset, Distances &); | ||
| DistributedTree const &tree, | ||
| Predicates const &queries, Distances const &, |
There was a problem hiding this comment.
Why did you do change
(indices, offsets, distances) -> (distances, indices, offsets)
and why did you const the distances?
There was a problem hiding this comment.
We only read the distances, and don't modify them. So const makes it clearer.
I changed the order to follow the same principle: input arguments followed by output arguments.
aprokop
force-pushed
the
some_distributed_cleanup
branch
from
aca1a96
to
b7bf542
Compare
|
Rebased on #1016. |
dalg24
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distancesargs inreassesStrategyanddeviseStrategyto constreassesStrategyanddeviseStrategyto align with queryBoundingVolumealias inDistributedTreeindicestonearest_ranksandintersected_ranksin DistributedTree queries implementation