AccessValues::_values data member should be private
#1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
commented
Jan 9, 2024
Comment on lines
+200
to
+202
| explicit AccessValues(Values values) | ||
| : _values(std::move(values)) | ||
| {} |
There was a problem hiding this comment.
This constructor was added as compared to the version I expect you reviewed.
There was a problem hiding this comment.
Why was it not in the original PR? Did it pass without somehow?
There was a problem hiding this comment.
Because I had not actually tried to compile. I extracted that from some other work when I discovered it was getting in my way.
aprokop
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I don't know what was wrong with #1018
I opened it as GH was having issues. I had uploaded a new version that never showed up and the CI would not trigger.