Generalize GetNeighborList for points

[aprokop]

• Make it work with any points
• Build the underlying BVH on points instead of boxes for performance
• Add (memory space, execution space) checks

[dalg24]

Although I don't see any issue with that change, you omitted to say that your PR now requires points as input which was not the case before.

[dalg24]

CTAD does not work here either?

[dalg24]

Should probably actually measure performance impact and not just add the GH label

[aprokop]

Although I don't see any issue with that change, you omitted to say that your PR now requires points as input which was not the case before.

It never worked worked correctly with anything but points.

Should probably actually measure performance impact and not just add the GH label

We don't have a neighbor list benchmark.

[dalg24]

Should probably actually measure performance impact and not just add the GH label

We don't have a neighbor list benchmark.

Crank the size up in the example. 100x100x100 will do on a GPU.

[aprokop]

Crank the size up in the example. 100x100x100 will do on a GPU.

What example? We don't use it in molecular_dynamics example, though I think you had a patch somewhere for it at some point.

[dalg24]

Ugggg. I thought we did...