Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ArborX_Version.hpp in ArborX.hpp #1031

Closed
wants to merge 1 commit into from

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jan 29, 2024

It is expected that

#include <ArborX.hpp>

int main()
{
  std::cout << ArborX::version() << std::endl;
  return 0;
}

should work. Not including ArborX_Version.hpp into ArborX.hpp was an oversight.

@aprokop aprokop added the bug Something isn't working label Jan 29, 2024
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strongly oppose
Pretty sure we had done that by design

@aprokop
Copy link
Contributor Author

aprokop commented Jan 29, 2024

Pretty sure we had done that by design

Not sure what design you are talking about.

@aprokop aprokop marked this pull request as draft January 29, 2024 21:43
@aprokop
Copy link
Contributor Author

aprokop commented Jan 29, 2024

@dalg24 rightfully pointed out that we modify the hash every time we rebuild. Meaning, that if we include the version file into ArborX.hpp, we'll rebuild everything everytime. Need to figure out whether it's possible to do the include only when we install.

@aprokop aprokop closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants