Auto-fetch benchmark when not available #1039
Conversation
| @@ -2,8 +2,32 @@ find_package(Boost 1.56.0 REQUIRED COMPONENTS program_options) | |||
|
|
|||
| # FIXME: when we start requiring benchmark >= 1.8.0, reenable | |||
| # "readability-redundant-string-cstr" check in .clang-tidy | |||
| find_package(benchmark 1.5.4 REQUIRED) | |||
| message(STATUS "Found benchmark: ${benchmark_DIR} (version \"${benchmark_VERSION}\")") | |||
| find_package(benchmark QUIET 1.5.4) | |||
There was a problem hiding this comment.
Tested with
find_package(benchmark QUIET 1.5.4 NO_DEFAULT_PATH)
| FetchContent_Declare( | ||
| googlebenchmark | ||
| DOWNLOAD_EXTRACT_TIMESTAMP FALSE | ||
| URL https://github.com/google/benchmark/archive/refs/tags/v1.8.0.tar.gz |
There was a problem hiding this comment.
Can you comment on the version you picked?
There was a problem hiding this comment.
I decided to up the version so that when we fix the comment about (about reenabling clang-tidy check), we would not need to change this. No other reason. The latest Google Benchmark is 1.8.3, so same major.
I am aware of the discussion in Kokkos about problems with fetching new versions in the original PR (something to do with Windows). I'm not sure whether that is still an issue.
There was a problem hiding this comment.
FYI benchmark Windows issue is still open: google/benchmark#1441. Kokkos deals with it by simply disabling benchmarks in Windows CI 😉
Sometimes :) Great artists steal. |
|
Build failures are not related. |
Based on work @cz4rs done for Kokkos.