Update DefaultIndexableGetter to work with all valid geometries

[aprokop]

Right now, DefaultIndexableGetter only passes through points and boxes, unnecessarily restricting things. One, for example, cannot do
ArborX::BVH<MemorySpace, Triangle> bvh(space, Kokkos::View<Triangle*>);.

This patch extends passed through geometries to all that are considered valid in GeometryTraits.

[dalg24]

Any example test to demonstrate that works with this patch?

[dalg24]

Also why did you classify this as a bug?

[aprokop]

Any example test to demonstrate that works with this patch?

We currently don't. The triangular example change in #936 still uses PairValueIndex.
I plan to introduce a distance to a triangular wall example in the near future that will exercise it.

Also why did you classify this as a bug?

Because it is impossible to construct BVH by passing all ArborX-native geometries. You can do
BVH<MemorySpace, Box> bvh(space, boxes);
but not
BVH<MemorySpace, Triangle> bvh(space, triangles);
This seems like unexpected behavior to me.

[dalg24]

Is that a regression? If not how is it a bug?
Also tests pass before and after (actually they don't and you didn't say why it is ok to merge with some build failing) your PR so how do we avoid regressions.
What was the rush to merge?

[aprokop]

It is not a regression in the usual sense. It is a bug because what i expected to work doesn't. You can say we didn't document that it does and that it's an enhancement then, but I did expect this to work, and was surprised that it didn't. So it's a bug in my eyes.

The builds passed. The only failures are the couple warnings from the build containers. So, i didn't feel there was much to document.

I merged it so that I could introduce the fix for temporaries. That PR would have conflicts with this one, and i felt this one was in a good enough state. I admit I rushed it.