Require Kokkos 4.2 #1054
Merged
Require Kokkos 4.2 #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
force-pushed
the
require_kokkos_4.2
branch
2 times, most recently
from
67b5dfb
to
1ae1ad5
Compare
Closed
aprokop
force-pushed
the
require_kokkos_4.2
branch
from
1ae1ad5
to
f9a2b9f
Compare
|
Rebased on #936 to resolve conflicts. |
dalg24
reviewed
Apr 12, 2024
| ARG KOKKOS_VERSION=4.1.00 | ||
| ARG KOKKOS_OPTIONS="-DKokkos_ENABLE_SYCL=ON -DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version -DKokkos_ENABLE_UNSUPPORTED_ARCHS=ON -DKokkos_ENABLE_DEPRECATED_CODE_3=OFF -DKokkos_ARCH_VOLTA70=ON -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_FLAGS=-w" | ||
| ARG KOKKOS_VERSION=4.3.00 | ||
| ARG KOKKOS_OPTIONS="-DKokkos_ENABLE_SYCL=ON -DCMAKE_CXX_FLAGS=-Wno-unknown-cuda-version -DKokkos_ENABLE_UNSUPPORTED_ARCHS=ON -DKokkos_ENABLE_DEPRECATED_CODE_3=OFF -DKokkos_ARCH_VOLTA70=ON -DKOKKOS_IMPL_SYCL_DEVICE_GLOBAL_SUPPORTED=0 -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_FLAGS=-w" |
There was a problem hiding this comment.
@masterleinad What's the deal with that extra option? Does Kokkos internal logic to set that variable fail?
There was a problem hiding this comment.
It's working fine for me on polaris and A100, i.e., newer versions of the compiler. We also explicitly disabled global device variable support in Kokkos since we had some problems, see https://github.com/kokkos/kokkos/blob/d88e2a5b0e7948c5315a605f5bc1ead00fc39fc6/.jenkins#L116.
There was a problem hiding this comment.
Also, this worked fine for Andrey for most test cases. We didn't quite understand why it was hanging in the Kokkos initialization for one if them. Again, this worked fine on polaris.
dalg24
approved these changes
Apr 15, 2024
masterleinad
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kokkos::printfunconditionally<Kokkos_Assert.hpp>header forKOKKOS_ASSERT