Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectify oversight that broke the CI #1055

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Rectify oversight that broke the CI #1055

merged 2 commits into from
Apr 5, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Apr 5, 2024 •
edited by dalg24

Fixup for #1045

  • Fix CUDA-Clang failure due to missing workaround for Clang in the test header
  • Fix unused variable warning due to using the wrong assertion macro

@aprokop aprokop added the testing Anything to do with tests and CI label Apr 5, 2024
@dalg24
Fix unused variable warning due to use of wrong Boost assertion macro
1481f5f 
```
<ArborX>/test/tstIndexableGetter.cpp:99:15: warning: unused variable 'scene_bounding_box' [-Wunused-variable]
  ArborX::Box scene_bounding_box = ArborX::Box{{-1, -1, -1}, {1, 1, 1}};
              ^
1 warning generated.
```
@dalg24 dalg24 changed the title Add missing header for CUDA clang workaround Correct oversight that broke the CI Apr 5, 2024
@dalg24 dalg24 changed the title Correct oversight that broke the CI Rectify oversight that broke the CI Apr 5, 2024
@aprokop aprokop merged commit 0e0411c into arborx:master Apr 5, 2024
2 checks passed
@aprokop aprokop deleted the fix_test branch April 5, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
testing Anything to do with tests and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aprokop @dalg24 @masterleinad