Improve distributed sorting of the results #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults If we only have one view to sort, we can do it in a single sweep using sort_by_key instead of first computing permutation and then applying it.
aprokop
changed the title
dalg24
approved these changes
Apr 11, 2024
| { | ||
| // If there's only one 1D view to process, we can avoid computing the | ||
| // permutation. | ||
| KokkosExt::sortByKey(space, keys, other_views...); |
There was a problem hiding this comment.
I would be interested in us implementing a variadic overload of sort by key which would allow us to just call that function unconditionally.
(Not asking to implement in this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sortResultsByKeyto make this clearer