Revert MI100->MI210 for nightly testing #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been failing.
|
I think it's worth to try to understand what's going on. The MI210 architecture is pretty much the same as the one used on Frontier. |
I agree. I'd like to have nightlies passing though. How about I create an issue to continue this discussion on? |
|
@aprokop sounds good |
Rombur
approved these changes
Apr 11, 2024
|
This now results in I'm baffled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightlies' HIP has been failing since #1048.
The change in continuous has been fine. But it broke the nightlies.
The alternative would be to upgrade nightly to ROCm 5.6. I have no strong opinion.
cc @Rombur