Exit early from unionFindWithingEachDistanceCell when n <= 1 #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
changed the title
…k trigger When Kokkos is compiled with Kokkos_ENABLE_DEBUG_BOUNDS_CHECK=ON, examples/dbscan reports ``` 1: Kokkos::RangePolicy bounds error: The lower bound (1) is greater than the upper bound (0). ``` This is coming from this function, where RangePolicy starts at 1. This is a minor change to exit early. An additional benefit is not launching the kernel when n == 0.
aprokop
changed the title
masterleinad
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kokkos is compiled with
Kokkos_ENABLE_DEBUG_BOUNDS_CHECK=ON, examples/dbscan reportsThis is coming from this function, where RangePolicy starts at 1. This is a minor change to exit early. An additional benefit is not launching the kernel when n <= 1.