Refactor distributed query internals #1073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprokop
commented
Apr 19, 2024
aprokop
commented
Apr 19, 2024
| std::tuple_element_t<0, std::tuple<OtherViews...>>::rank == 1) | ||
| using ViewType = std::tuple_element_t<0, std::tuple<OtherViews...>>; | ||
| if constexpr (sizeof...(OtherViews) == 1 && ViewType::rank == 1 && | ||
| std::is_arithmetic_v<typename ViewType::value_type>) |
There was a problem hiding this comment.
Had to add this to not provide comparison operators for pair values.
aprokop
force-pushed
the
distributed_refactor
branch
from
d85d2d5
to
13efd99
Compare
- Do not spit out values in phase I - Switch to using nth_element (based on quickselect) for finding farthest distance
aprokop
force-pushed
the
distributed_refactor
branch
from
13efd99
to
bc6f62e
Compare
|
I'd like to see this merged, as it is blocking more changes in the distributed framework. @masterleinad or @dalg24 can one of you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forwardQueriesAndCommunicateResultsqueryDispatchImplintophaseIandphaseIIwith interfaces making clear which data is passed whereThe overall goal of the PR is to prepare for reduce complexity. This should also help with the introduction of the nearest callbacks.