Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated InlineCallbackTag and ArborX::Traits #1078

Merged
merged 2 commits into from
May 2, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented May 1, 2024

All things are 2+ years old.

Deprecated in d24af2a
2+ years ago (March 2022).
@aprokop aprokop changed the title Remove deprecated InlineCallbackTag and ArborX::Traits Remove deprecated InlineCallbackTag and ArborX::Traits May 1, 2024
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to remove

// check_valid_access_traits(PrimitivesTag{}, LegacyAccessTraits{});

@aprokop aprokop added the backward incompatible Modifications that may break users' code label May 1, 2024
@aprokop aprokop merged commit 2e28fe8 into arborx:master May 2, 2024
1 of 2 checks passed
@aprokop aprokop deleted the remove_deprecations branch May 2, 2024 14:44
@aprokop
Copy link
Contributor Author

aprokop commented May 2, 2024

Couple builds not started, ignoring.

@aprokop aprokop mentioned this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward incompatible Modifications that may break users' code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants