Move distributed TimeMonitor in a separate header #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
May 3, 2024
Mainly because it is easier. And if we introduce testing for it at some point (which we should), it would be hard to do that in benchmarks. We don't have a special place in benchmarks for utils. Guess we could make something like |
|
I'd prefer keeping it in benchmarks/ |
dalg24
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing a second benchmark (distributed nearest to wall) that would need this utility. So, moving it out of the current distributed benchmark. Code is unchanged.
Ideally, we would add tests at some point. Out of scope in this PR, though.