Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move point clouds to benchmarks/utils #1081

Merged
merged 3 commits into from
May 4, 2024
Merged

Move point clouds to benchmarks/utils #1081

merged 3 commits into from
May 4, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented May 3, 2024 •
edited

  • Move point clouds to benchmark/utils
  • Move the code itself into ArborXBenchmark namespace
  • Rename files to camel case

dalg24
dalg24 reviewed May 3, 2024
View reviewed changes
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to say rename the files to ArborXBenchmark_PascalCaseName.hpp

benchmarks/bvh_driver/CMakeLists.txt Outdated Show resolved Hide resolved
@aprokop
Copy link
Contributor Author

aprokop commented May 3, 2024

I'd be tempted to say rename the files to ArborXBenchmark_PascalCaseName.hpp

I thought about it and would be fine, just wanted to keep the diff down.

@aprokop
Copy link
Contributor Author

aprokop commented May 3, 2024

I'd be tempted to say rename the files to ArborXBenchmark_PascalCaseName.hpp

Done.

@aprokop aprokop merged commit b05b5f7 into arborx:master May 4, 2024
2 checks passed
@aprokop aprokop deleted the point_clouds branch May 4, 2024 00:17
@aprokop aprokop mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aprokop @dalg24