-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using expand for scene reductions #1082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4ab80f
to
4416b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of avoiding using operator+=
and Kokkos::Sum
.
Co-authored-by: Daniel Arndt <arndtd@ornl.com>
masterleinad
approved these changes
May 13, 2024
CUDA builds did not start (failed to check out the source). SYCL timed out. That's ok. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we do a combination of
+=
andexpand
in our reduction. I would like to switch to only usingexpand
in order to make the geometric algorithms a general as possible.+=
relies on internal implementation, whileexpand()
tells us exactly what operations a, say,Box
geometry is required to provide.The goal here is to move all stuff from inside the geometry classes (this includes KDOP and Ray, too) into generic algorithms.
reduction_identity
inArborX::Box
andArborX::ExperimentalHyperGeometry::Box
(not sure why we didn't have one in KDOP)+=
inArborX::Box
+=
inArborX::ExperimentalHyperGeometry::Box
join
operation usingexpand
expand(Box, Point)
andexpand(Box, Box)
Note that I didn't have to change
tstCompileOnlyTypeRequirement.cpp
test.Next step would be redoing KDOP geometry in #982 to include dimension and coordinate, and reorganize it so that there are no internal class functions.