Add KokkosExt::{construct_at,destroy_at} #1084
Conversation
|
@dalg24 Done. |
src/kokkos_ext/ArborX_DetailsKokkosExtUninitializedMemoryAlgorithms.hpp
Outdated
Show resolved
Hide resolved
src/kokkos_ext/ArborX_DetailsKokkosExtUninitializedMemoryAlgorithms.hpp
Outdated
Show resolved
Hide resolved
| Kokkos::deep_copy(exec, view_host, view); | ||
| BOOST_TEST(view_host(0).value == -1); | ||
| BOOST_TEST(view_host(1).value == -1); | ||
| } |
There was a problem hiding this comment.
Do we want to check using these in constant expressions (if C++20 is available for construct_at)?
There was a problem hiding this comment.
I'm not sure. Seems like an overkill at the moment.
| #include "BoostTest_CUDA_clang_workarounds.hpp" | ||
| #include <boost/test/unit_test.hpp> | ||
|
|
||
| #define BOOST_TEST_MODULE KokkosExtUninitializedMemoryAlgorithms |
There was a problem hiding this comment.
Sorry for noticing late but what is the intent here? I don't think that does what we think assuming the intent was to resister a test suite with all unit tests in that source file.
There was a problem hiding this comment.
What do you mean? I'm not 100% familiar with what it does, and just followed the way it's done in other KokkosExt testing files. From the documentation it seems that it only needs to be done in one translation module and before inclusion of unit_test.hpp header.
No description provided.