Work around compiler bugs in HIP in LinearBVH test #442
Conversation
| @@ -740,6 +740,10 @@ BOOST_AUTO_TEST_CASE_TEMPLATE(callback_with_attachment, DeviceType, | |||
| } | |||
| } | |||
|
|
|||
| // FIXME temporary workaround bug in HIP-Clang (register spill) and SYCL | |||
| #if defined(KOKKOS_ENABLE_HIP) || defined(KOKKOS_ENABLE_SYCL) | |||
| BOOST_TEST_DECORATOR(*boost::unit_test::expected_failures(5)) | |||
There was a problem hiding this comment.
How did you come up with that number? I'd rather look into upgrading to ROCm 4.0
Also we need to investigate a bit more the SYCL issues.
There was a problem hiding this comment.
This is the number of calls to BOOST_TEST in this test. It could be lower than that, but I see no point trying to be precise, as for me the test is dead anyway in those configurations.
|
I think the cleanup of the "structured grid" unit test is a good change, but it conflicts with my upcoming reorganization of the tree unit tests |
|
@dalg24 Then please go ahead and cherry pick up the changes in this PR into your upcoming PR. I'll close this if you agree. |
|
I removed SYCL check, but left the HIP one. We know that HIP fails sporadically in this test due to register spills, so it's an improvement of status quo. I think it should be merged in this form. |
aprokop
changed the title
This reverts commit bfa5410.
aprokop
force-pushed
the
workaround_hip_sycl
branch
from
b7d3f92
to
c7ae97d
Compare
|
As @dalg24 is doing the very necessary refactoring of the tests, and this PR conflicts with those changes, this will not be merged. Any interesting pieces could be cherrypicked, so not removing the branch for a while. Closing. |
No description provided.