Update HIP CI build ROCm 4.2 -> 5.0 #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake 3.18.5 -> 3.22.4 Boost 1.72.0 -> 1.79.0 Google Benmchark 1.5.0 -> 1.6.1
|
Expired CMake key. |
|
No that is not the issue. See kokkos/kokkos#4601 |
|
Starting from 1.76.0, the place we download boost from (e.g., 1.79.0) do not carry |
jfrog stopped providing .asc files after 1.75.0.
|
Test this please |
|
test this please |
|
Retest this please |
3 similar comments
|
Retest this please |
|
Retest this please |
|
Retest this please |
aprokop
previously approved these changes
May 27, 2022
|
Retest this please |
|
I wasn't able to reproduce the HIP failure (cmake not finding MPI) |
aprokop
dismissed
their stale review
The success check was not actually successful.
Should not actually matter but I am running out of ideas
|
Hmm, HIP took 40 minutes to build. Wonder if it's related to #652. In the previous HIP 4.2 test build we had The new 5.0 test build has |
|
With building just one target, the build now takes about 15 minutes. Still longer than it used to be, but it's acceptable. |
aprokop
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.18.5 -> 3.22.4
Boost 1.72.0 -> 1.79.0
Google Benmchark 1.5.0 -> 1.6.1