Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few clang-tidy complaints #88

Merged
merged 1 commit into from Aug 7, 2019
Merged

Fix a few clang-tidy complaints #88

merged 1 commit into from Aug 7, 2019

Conversation

masterleinad
Copy link
Collaborator

Running clang-tidy really didn't yield much, but this still looks nicer.

dalg24
dalg24 reviewed Jul 9, 2019
View reviewed changes
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the warning?

@masterleinad
Copy link
Collaborator Author 

warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]

dalg24
dalg24 approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please propose a .clang-tidy file (separate PR is fine) so we lay the ground for automated checks?

@masterleinad masterleinad mentioned this pull request Jul 10, 2019
Merged
@dalg24 dalg24 merged commit 6f49b54 into arborx:master Aug 7, 2019
@masterleinad masterleinad deleted the fix_clang_tidy_warning branch February 29, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masterleinad @dalg24