Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default BoundingVolume for BasicBVH to the right dimensionality #914

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Change default BoundingVolume for BasicBVH to the right dimensionality #914

merged 2 commits into from
Jul 24, 2023

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Jul 24, 2023

The right dimensionality of the box depends on the return type of the IndexableGetter.

@aprokop aprokop added the enhancement New feature or request label Jul 24, 2023
masterleinad
masterleinad approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@aprokop aprokop merged commit 244e49d into arborx:master Jul 24, 2023
1 check was pending
@aprokop aprokop deleted the change_default_volume branch July 24, 2023 19:58
@aprokop aprokop mentioned this pull request Jul 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aprokop @masterleinad