Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Change the color of seperators in context menus #158

Closed
wants to merge 1 commit into from

Conversation

cynecx
Copy link

@cynecx cynecx commented Oct 23, 2018

Before:

before

After:

after

@NicoHood NicoHood modified the milestones: Next Release, Next-2Release Oct 24, 2018
@NicoHood
Copy link
Collaborator

Does this only happen with the dark theme? Because with the darker theme it look good to me.

@jnsh
Copy link
Contributor

jnsh commented Oct 25, 2018

First, the original design by @horst3180 uses light separator for dark menus, and IMHO there would have to be a very good reason to change that.

Second, any such changes would have be applied to all themes, i.e. all gtk3 theme versions, gtk2 theme, gnome-shell theme, etc.

@NicoHood
Copy link
Collaborator

I like the idea.

@fossfreedom
Copy link
Collaborator

Agreed - this should be merged only when similar changes are made for gtk2 gnome shell etc otherwise we get a inconsistent approach.

@qwertychouskie
Copy link

@cynecx What's the status on this? Can you implement the change for GTK2 also so it can be merged?

@NicoHood NicoHood modified the milestones: Next-2-Release, Future Mar 30, 2019
@fossfreedom
Copy link
Collaborator

This PR diverts from the original arc design. I don't see a consensus here and it needs more work anyway to make it GTK+2 compliant. So I'll close this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants