Resolve jumping cinnamon panel icons - upstream #852

[fossfreedom]

resolves upstream https://i.imgur.com/xps3bIc.mp4

tested cinnamon 3.4.6 on ubuntu 17.10

[NicoHood]

Have you generated the css files using gulp? I am unable to test right now. The changes look good to me though.

[fossfreedom]

Yep - I just take the PR scss, merge it - i.e. I dont merge the CSS stuff. Then generate the theme via gulp. Install and test.

[NicoHood]

Nice! You should be familiar with gpg and commit signing, could you please enable commit signing for git and future commits? git config --global commit.gpgsign true and git config --global user.signingkey <fingerprint>

Lets merge this one.

[pizzadude]

@fossfreedom @NicoHood still happens on linux mint 18.3 cinnamon (ubuntu 16.04)

I don't think it happened before the last update.

[NicoHood]

@pizzadude Can you please give us more detailed information on that? Which version/commit worked and which broke?

[pizzadude]

@NicoHood I'm not 100% certain but I'm pretty sure it happened after the latest update, that I just applied. I'm using @fossfreedom 's PPA. (though it could of always been there and i might have not noticed it)

If I run "aptitude show arc-theme" it shows the version is:

20180114-0+201801242050~ubuntu16.04.1

In /var/log/apt/history.log, it shows it was upgraded from:

20180114-0+201801182048~ubuntu16.04.1

Cinnamon version is: 3.6.7

This is what the issue looks like:

https://i.imgur.com/4HKUaE2.mp4

[fossfreedom]

@pizzadude at a guess maybe a cinnamon update broke the padding that fixed it last time?

i.e. I tested the cinnamon version 3.4.6 - you seem to be running a much later version.

Please have a look - give us a PR and we'll merge it in.

a1a9822

[pizzadude]

@fossfreedom I'm not a developer by any means.....but I fixed it. PR incoming...

[pizzadude]

Nevermind about the PR, as I have no idea how to work with these theme files except editing them directly. (I don't see any cinnamon.css or cinnamon-dark.css in the repo) But I will show you how I fixed it:

On the ".panel bottom" line, if you add "margin-top: 0;" it fixes it
And vise versa for the ".panel top" line, adding "margin-bottom: 0;" it fixes it for the top panel.

The code looks like this, and in the current version, it starts on line 1306. In that revision you linked, it was on line 1308.

  .panel-bottom .panel-launcher, .panel-bottom
  .launcher {
    margin-top: 0;
    margin-bottom: 0; }
  .panel-top .panel-launcher, .panel-top
  .launcher {
    margin-top: 0;
    margin-bottom: 0;
    padding-top: 0; }

(tested on cinnamon-dark.css) : /usr/share/themes/Arc-Dark/cinnamon/cinnamon.css

@NicoHood @fossfreedom

[fossfreedom]

@NicoHood the file to change to include the changes is common/cinnamon/sass/_common.scss

I can make the change and visually check the resultant CSS to ensure it look likes the above - do you want me to make the change directly?

[pizzadude]

well...i ended up submitting a PR but can you guys test it first : P
edit: I tested my PR and it works.

[NicoHood]

This is the PR:
#51

@fossfreedom Questions answered/solved?

[fossfreedom]

yep