Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lint, props validation error #1026

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

ManishMadan2882
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fixes errors produced on pre-commit npm run lint
96:42 error 'progress.percentage' is missing in props validation react/prop-types
125:22 error 'progress.percentage' is missing in props validation react/prop-types
128:65 error 'progress.taskId' is missing in props validation react/prop-types
190:34 error 'progress.percentage' is missing in props validation react/prop-types
191:29 error 'progress.failed' is missing in props validation react/prop-types
257:40 warning 'isDragActive' is assigned a value but never used @typescript-eslint/no-unused-vars
291:17 error 'progress.type' is missing in props validation react/prop-types
293:24 error 'progress.type' is missing in props validation react/prop-types
  • Changed props variable name from progress to progressPercent for ProgressBar component inside Upload component
  • Lint errors where because of ambiguity in variable names, progress is already defined in the scope of Upload component
  • Why was this change needed? (You can also link to an open issue here)
    • Smooth pre-commit checks and formatting

Copy link

vercel bot commented Jul 3, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@dartpain dartpain merged commit ffddf10 into arc53:main Jul 3, 2024
6 of 7 checks passed
@dartpain
Copy link
Contributor

dartpain commented Jul 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants