added modal to select source documentation #103
Conversation
added modal to select source documentation
small fixes
small nav fix
|
Since docs are being fetched from the network. We should show something to represent loading state when Docs modal is launched in case of delay. Can be done in next PR. |
frontend/src/api/docs.ts
Outdated
| } catch (error) { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Since functionality in this file is unique to preference feature, it could be moved inside preference folder.
Something like this : https://github.com/arc53/DocsGPT/blob/main/frontend/src/conversation/conversationApi.ts
frontend/src/models/misc.ts
Outdated
| dat: string; | ||
| docLink: string; | ||
| model: string; | ||
| }; |
There was a problem hiding this comment.
Since this type is unique to preference feature, it could be moved inside preference folder as well.
|
|
||
| const isSelectedDocsSet = useSelector(selectSelectedDocsStatus); | ||
| const [selectedDocsModalState, setSelectedDocsModalState] = | ||
| useState<ActiveState>(isSelectedDocsSet ? 'INACTIVE' : 'ACTIVE'); |
There was a problem hiding this comment.
we gotta put the two modal opening in sequence, can do it in the next PR.
| isCancellable?: boolean; | ||
| }) { | ||
| const dispatch = useDispatch(); | ||
| const [docs, setDocs] = useState<Doc[] | null>(null); |
There was a problem hiding this comment.
I am on the fence about where to put all of the docs collection inside component state or redux. On one hand it feels like its okay as long as curently selected doc is in redux. On other hand, it feels like next upcoming feature(upload #105) would require all docs to be in redux so that new doc could be added when user decides to upload a doc . Ill let @TaylorS15 and @dartpain handle this one.
There was a problem hiding this comment.
Agreed, because of upcoming feature i think its best if its in the redux
|
Everything has been changed per comments except for navigation opening the modals in sequence. |
Moved /api/docs.ts to /preference/selectDocsApi.ts Added all source docs to redux
review changes
little change
removed logging
added api/docs.ts to fetch default source docs
added new reducer to preferenceSlice
added button in navigation to open modal