Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add scroll to bottom button #363

Merged
merged 2 commits into from
Oct 1, 2023
Merged

feat(ui): add scroll to bottom button #363

merged 2 commits into from
Oct 1, 2023

Conversation

hirenchauhan2
Copy link
Contributor

This will show the scroll to bottom button when user scrolls to top from the last message.

Closes #170

This will show the scroll to bottom button when user scrolls to top from the last message.

Closes #170
@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 8:58pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 8:58pm

@hirenchauhan2
Copy link
Contributor Author

hirenchauhan2 commented Oct 1, 2023

For developing this part I had to use the mock data from the app as I was not able to run the back-end app due to some issues in my python installation in WSL. I'm not super comfortable in fixing python side of issues. I also commented the code which shows the Select Source Documentation modal in my local code in order to work freely on the required task

@hirenchauhan2
Copy link
Contributor Author

In the preview, the Select Source Documentation modal does not go away due to CORS error from the API.

@dartpain
Copy link
Contributor

dartpain commented Oct 1, 2023

Good commit,
There is one small thing you need to add before ill merge the PR,

Basically if user is at the bottom of the screen, the arrow should dissapear.
I see that you tried to implement it in code but I guess you have to tweak few things.

Also even if you can't launch backend just try it with error messages too

Btw looks good on mobile too!

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #363 (153b5c0) into main (b47ecab) will increase coverage by 0.02%.
Report is 24 commits behind head on main.
The diff coverage is 20.11%.

❗ Current head 153b5c0 differs from pull request most recent head af0e648. Consider uploading reports for the commit af0e648 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   16.00%   16.02%   +0.02%     
==========================================
  Files          59       59              
  Lines        2668     2664       -4     
==========================================
  Hits          427      427              
+ Misses       2241     2237       -4     
Files Coverage Δ
application/core/settings.py 100.00% <100.00%> (ø)
application/vectorstore/base.py 40.00% <100.00%> (ø)
application/api/answer/routes.py 25.56% <33.33%> (+0.56%) ⬆️
application/vectorstore/vector_creator.py 60.00% <60.00%> (ø)
application/vectorstore/faiss.py 50.00% <37.50%> (ø)
application/parser/open_ai_func.py 19.60% <22.22%> (ø)
application/worker.py 29.23% <0.00%> (ø)
application/api/user/routes.py 27.48% <7.69%> (ø)
application/api/internal/routes.py 34.04% <0.00%> (ø)
application/vectorstore/elasticsearch.py 14.89% <14.89%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain
Copy link
Contributor

dartpain commented Oct 1, 2023

Just added [endMessageRef.current] to deps, seems to fix the issue

@dartpain dartpain merged commit 05ec121 into arc53:main Oct 1, 2023
7 checks passed
@dartpain
Copy link
Contributor

dartpain commented Oct 3, 2023

@holopin-bot
Copy link

holopin-bot bot commented Oct 3, 2023

Congratulations @hirenchauhan2, you just earned a badge! Here it is: https://holopin.io/claim/clna3r7h1365560fmc3vyvkeoy

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Update. Added arrow to go back to the end of conversation
2 participants