Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified README resolving issue #457 #460

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Modified README resolving issue #457 #460

merged 3 commits into from
Oct 14, 2023

Conversation

alienishi
Copy link
Contributor

@alienishi alienishi commented Oct 6, 2023

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 1:33pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 1:33pm

@alienishi
Copy link
Contributor Author

@dartpain
Can you please add the Hacktoberfest-accepted label to this assessment , My contribution will not be accepted in Hacktoberfest if the label is absent. Thanks :)

@dartpain dartpain linked an issue Oct 7, 2023 that may be closed by this pull request
@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2023

It will count towards your score even if its not labelled
Also its not really storage. Just remove "and storage" part

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #460 (e9c4b0d) into main (c969e9c) will decrease coverage by 1.57%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head e9c4b0d differs from pull request most recent head 1f8643c. Consider uploading reports for the commit 1f8643c to get more accurate results

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   17.57%   16.01%   -1.57%     
==========================================
  Files          59       59              
  Lines        2720     2667      -53     
==========================================
- Hits          478      427      -51     
+ Misses       2242     2240       -2     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented Oct 14, 2023

@alienishi is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@alienishi
Copy link
Contributor Author

@dartpain I have made the changes suggested by you.
Please review it and if according to the guidelines then please do merge it
It will help me in hacksquad :)

@dartpain dartpain merged commit c97a55e into arc53:main Oct 14, 2023
6 of 7 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @alienishi

@holopin-bot
Copy link

holopin-bot bot commented Oct 14, 2023

Congratulations @alienishi, you just earned a badge! Here it is: https://holopin.io/claim/clnqgf85677140fmdxpb59cum

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of "store" in README
2 participants