Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Conversations tabs overlapping #472

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Conversation

adityagupta19
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fixed: Tabs overlapping due to text overflow by limiting the text length.
  • Why was this change needed? (You can also link to an open issue here)
    Tabs overlap issue
  • Other information:
  • before :
    Screenshot 2023-10-06 231343
    -after :
    Screenshot 2023-10-06 230713

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:18pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:18pm

@vercel
Copy link

vercel bot commented Oct 6, 2023

@adityagupta19 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #472 (943bf47) into main (17edaa0) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   17.50%   17.50%           
=======================================
  Files          59       59           
  Lines        2719     2719           
=======================================
  Hits          476      476           
  Misses       2243     2243           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain
Copy link
Contributor

dartpain commented Oct 6, 2023

Thank you!
@holopin-bot @adityagupta19

@holopin-bot
Copy link

holopin-bot bot commented Oct 6, 2023

Congratulations @adityagupta19, you just earned a badge! Here it is: https://holopin.io/claim/clnf47i4u45320fl60d7rmsfw

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain dartpain merged commit 3182816 into arc53:main Oct 6, 2023
8 of 9 checks passed
@larinam
Copy link
Collaborator

larinam commented Oct 7, 2023

@adityagupta19, thank you for your contribution!

The provided solution is functional and good, but a more beautiful solution would be to use style attribute for text overflow:
text-overflow: ellipsis;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants