Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krishvsoni patch 1 #486

Merged
merged 7 commits into from
Oct 7, 2023
Merged

Krishvsoni patch 1 #486

merged 7 commits into from
Oct 7, 2023

Conversation

krishvsoni
Copy link
Contributor

  • What kind of change does this PR introduce? - Docs Update

  • Why was this change needed? - Adding both activation commands (venv/Scripts/activate and . venv/bin/activate) is necessary to accommodate users on different operating systems (Windows, Unix-based) and provide clear, error-free instructions in the Readme markdown file.

  • Other information:
    I initially attempted to use the default command . venv/bin/activate, but it didn't work for me. This prompted me to include the alternative venv/Scripts/activate command in the README for Windows users like me.

@vercel
Copy link

vercel bot commented Oct 7, 2023

@krishvsoni is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the repo label Oct 7, 2023
@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 11:15pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 11:15pm

@larinam
Copy link
Collaborator

larinam commented Oct 7, 2023

Thank you for your contribution.

If this change eventually will be accepted, please also add link to official Python documentation somewhere in your changes or aroud (https://docs.python.org/3/tutorial/venv.html)

@krishvsoni
Copy link
Contributor Author

Official documentation added for virtual env

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@krishvsoni
Copy link
Contributor Author

Thank you for your contribution.

If this change eventually will be accepted, please also add link to official Python documentation somewhere in your changes or aroud (https://docs.python.org/3/tutorial/venv.html)

From this I added the documentation link with the commands

@dartpain
Copy link
Contributor

dartpain commented Oct 7, 2023

@holopin-bot @krishvsoni Thank you!

@holopin-bot
Copy link

holopin-bot bot commented Oct 7, 2023

Congratulations @krishvsoni, you just earned a badge! Here it is: https://holopin.io/claim/clngnlzq4134050fmnfdbtwk66

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #486 (47f9be3) into main (17edaa0) will not change coverage.
Report is 38 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   17.50%   17.50%           
=======================================
  Files          59       59           
  Lines        2719     2719           
=======================================
  Hits          476      476           
  Misses       2243     2243           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain dartpain merged commit e18189c into arc53:main Oct 7, 2023
10 checks passed
@krishvsoni
Copy link
Contributor Author

krishvsoni commented Oct 8, 2023

@dartpain
I am very grateful to you. Thanks for merging my pull request.
@larinam thanks for maintaining this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants