Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Code Refactoring for Better Readability and Scalability #530

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

robbiebusinessacc
Copy link
Contributor

Overview
This pull request introduces changes to the backend code to enhance its readability, maintainability, and scalability.

Changes:

  1. Simplified Conditional for API Call
    Reduced redundant conditions for determining when to call the OpenAI API.

  2. Concise String Manipulation
    Optimized the string manipulation method for joining parts of a title.

  3. Scalable Code for Language Support
    Introduced a dictionary-based approach for language support, making it more scalable. This ensures that new languages can be added in the future with minimal changes, as opposed to multiple conditional statements.

Conclusion:
These backend modifications aim to make the codebase more intuitive and future-proof. Feedback is appreciated.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 10:38pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 10:38pm

@vercel
Copy link

vercel bot commented Oct 9, 2023

@robbiebusinessacc is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #530 (4d92606) into main (e108833) will increase coverage by 0.03%.
Report is 24 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   17.50%   17.54%   +0.03%     
==========================================
  Files          59       59              
  Lines        2719     2713       -6     
==========================================
  Hits          476      476              
+ Misses       2243     2237       -6     
Files Coverage Δ
application/worker.py 29.68% <0.00%> (+0.45%) ⬆️
scripts/ingest.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain dartpain merged commit 808b291 into arc53:main Oct 9, 2023
9 of 10 checks passed
@dartpain
Copy link
Contributor

dartpain commented Oct 9, 2023

@holopin-bot @robbiebusinessacc Thank you!

@holopin-bot
Copy link

holopin-bot bot commented Oct 9, 2023

Congratulations @robbiebusinessacc, you just earned a badge! Here it is: https://holopin.io/claim/clnjh82pk32890flc7y1ynl9d

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@dartpain
Copy link
Contributor

dartpain commented Nov 8, 2023

@robbiebusinessacc we are finalising our order for shirts, we need an address to send your shirt to, please fill this in
https://airtable.com/appfkqFVjB0RpYCJh/shrXXM98xgRsbjO7s

@robbiebusinessacc robbiebusinessacc deleted the patch-1 branch January 23, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application Application scripts Scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants