Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Train button Disabled Before Selecting File #558

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Train button Disabled Before Selecting File #558

merged 5 commits into from
Oct 14, 2023

Conversation

MSaiKiran9
Copy link
Contributor

@MSaiKiran9 MSaiKiran9 commented Oct 11, 2023

before

I introduced two changes in it i added a red asterisk denoting user must choose file in order to enable train button as no file is selected above it's disabled above

After File Selection:

after

After selecting some file the Train button will be enabled and pointer will be cursor on it

  • Why was this change needed? (You can also link to an open issue here)
    This change is needed because if a user trains without giving any file then the website is staying idle in uploading state
  • Other information:

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 7:38pm
nextra-docsgpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 7:38pm

@vercel
Copy link

vercel bot commented Oct 11, 2023

@MSaiKiran9 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #558 (993c9b3) into main (c969e9c) will not change coverage.
Report is 19 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   17.57%   17.57%           
=======================================
  Files          59       59           
  Lines        2720     2720           
=======================================
  Hits          478      478           
  Misses       2242     2242           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dartpain
Copy link
Contributor

dartpain commented Oct 11, 2023

@tenokami How should a disabled button look? and please confirm if you need any changes

@MSaiKiran9 Thank you a lot!

@tenokami
Copy link
Collaborator

tenokami commented Oct 12, 2023

Text opacity: 80%
Button background opacity: 75%

image

@MSaiKiran9 l @dartpain

@tenokami
Copy link
Collaborator

@MSaiKiran9 I would accept the disabled button state and look, but I wouldn't add the asterisk. Thank you

@MSaiKiran9
Copy link
Contributor Author

MSaiKiran9 commented Oct 12, 2023

@MSaiKiran9 I would accept the disabled button state and look, but I wouldn't add the asterisk. Thank you
@tenokami
Should i remove the asterisk & change the background and text opacity of disabled button as you suggested above with purpule colour ? (Or) I should only remove asterisk

@tenokami
Copy link
Collaborator

remove the asterisk & change the background and text opacity of disabled button please @MSaiKiran9

@MSaiKiran9
Copy link
Contributor Author

MSaiKiran9 commented Oct 12, 2023

without-file ---> When no file is selected withfilesel --->When a file is selected

Is it okay now @tenokami

@tenokami
Copy link
Collaborator

tenokami commented Oct 12, 2023

@MSaiKiran9 I like it! Thanks

@MSaiKiran9
Copy link
Contributor Author

Ok i'm updating the pr !

@MSaiKiran9
Copy link
Contributor Author

MSaiKiran9 commented Oct 12, 2023

@tenokami done

@tenokami
Copy link
Collaborator

Waiting for @dartpain

@MSaiKiran9
Copy link
Contributor Author

@dartpain Let me know if it's okay

@dartpain dartpain merged commit fde8de8 into arc53:main Oct 14, 2023
10 checks passed
@dartpain
Copy link
Contributor

@holopin-bot @MSaiKiran9

@holopin-bot
Copy link

holopin-bot bot commented Oct 14, 2023

Congratulations @MSaiKiran9, you just earned a badge! Here it is: https://holopin.io/claim/clnqg54lj27460fmhoid3zk1b

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@MSaiKiran9 MSaiKiran9 deleted the train-button branch October 15, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants