-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Train button Disabled Before Selecting File #558
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MSaiKiran9 is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 17.57% 17.57%
=======================================
Files 59 59
Lines 2720 2720
=======================================
Hits 478 478
Misses 2242 2242 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@tenokami How should a disabled button look? and please confirm if you need any changes @MSaiKiran9 Thank you a lot! |
Text opacity: 80% |
@MSaiKiran9 I would accept the disabled button state and look, but I wouldn't add the asterisk. Thank you |
|
remove the asterisk & change the background and text opacity of disabled button please @MSaiKiran9 |
---> When no file is selected
--->When a file is selected
Is it okay now @tenokami |
@MSaiKiran9 I like it! Thanks |
Ok i'm updating the pr ! |
@tenokami done |
Waiting for @dartpain |
@dartpain Let me know if it's okay |
Congratulations @MSaiKiran9, you just earned a badge! Here it is: https://holopin.io/claim/clnqg54lj27460fmhoid3zk1b This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It solved issue 🐛 Bug Report: When file isn't selected website should disable train button #539
Before File Selection:
I introduced two changes in it i added a red asterisk denoting user must choose file in order to enable train button as no file is selected above it's disabled above
After File Selection:
After selecting some file the Train button will be enabled and pointer will be cursor on it
This change is needed because if a user trains without giving any file then the website is staying idle in uploading state