Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes input field absolute in Conversation, fixes delete icon in Settings/Documents #848

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

ManishMadan2882
Copy link
Collaborator

@ManishMadan2882 ManishMadan2882 commented Feb 9, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Fixes improper button removal after deletion of documents in settings.
  • Reused the reducer to setSourceDocs() ensuring proper deletion of complete row from the UI.
  • Fixes Input box in the Conversation, making it absolute with respect to the conversation bubbles.
    Screenshot from 2024-02-09 19-11-38
  • Why was this change needed? (You can also link to an open issue here)

Copy link

vercel bot commented Feb 9, 2024

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (615d549) 19.13% compared to head (8826f0f) 19.13%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #848   +/-   ##
=======================================
  Coverage   19.13%   19.13%           
=======================================
  Files          65       65           
  Lines        3016     3016           
=======================================
  Hits          577      577           
  Misses       2439     2439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManishMadan2882 ManishMadan2882 changed the title fix(settings): delete button Makes input field absolute in Conversation, fixes delete icon in Settings/Documents Feb 9, 2024
Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, thank you!

@dartpain dartpain merged commit 2c99158 into arc53:main Feb 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: When delete button is pressed in the settings menu, it is not displayed in UI correctly
2 participants