Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reddit loader #877

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Added reddit loader #877

merged 5 commits into from
Mar 27, 2024

Conversation

siiddhantt
Copy link
Collaborator

Copy link

vercel bot commented Mar 16, 2024

@siiddhantt is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 18.36735% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 20.05%. Comparing base (31d9478) to head (e010714).
Report is 1 commits behind head on main.

Files Patch % Lines
application/worker.py 12.90% 27 Missing ⚠️
application/parser/remote/reddit_loader.py 25.00% 12 Missing ⚠️
application/parser/remote/remote_creator.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   20.00%   20.05%   +0.04%     
==========================================
  Files          72       73       +1     
  Lines        3264     3281      +17     
==========================================
+ Hits          653      658       +5     
- Misses       2611     2623      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 1:55pm

Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change that will allow users to pass number of posts as a parameter

application/parser/remote/reddit_loader.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dartpain dartpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, Thank you!

@dartpain dartpain merged commit 5e5e2b8 into arc53:main Mar 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants