Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature #887 #895

Merged
merged 2 commits into from
Apr 3, 2024
Merged

added feature #887 #895

merged 2 commits into from
Apr 3, 2024

Conversation

sarfarazsiddiquii
Copy link
Contributor

This PR (ref #887 ) introduces a new feature that changes the default document selection to "Empty" and ensures that when no document is selected, chunks processed per query are set to 0.

Currently default document has DocsGPT documentation which was confusing.

Copy link

vercel bot commented Mar 30, 2024

@sarfarazsiddiquii is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 3:54pm

@dartpain
Copy link
Contributor

dartpain commented Apr 3, 2024

Thank you so much for your PR.
There are a few adjustments that are needed to make it work:
Inside frontend/src/conversation/conversationApi.ts you need to make sure that
fetchAnswerApi, fetchAnswerSteaming and searchEndpoint can handle a new type for a selectedDocs: Doc,
After this slight adjustment it should all work well.

@sarfarazsiddiquii
Copy link
Contributor Author

sarfarazsiddiquii commented Apr 3, 2024

Thank you @dartpain for your feedback. I've updated fetchAnswerApi, fetchAnswerSteaming, and searchEndpoint to correctly handle selectedDocs: Doc | null as suggested

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 20.16%. Comparing base (794fc05) to head (02d4f7f).
Report is 5 commits behind head on main.

Files Patch % Lines
application/api/answer/routes.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   20.17%   20.16%   -0.02%     
==========================================
  Files          73       73              
  Lines        3311     3313       +2     
==========================================
  Hits          668      668              
- Misses       2643     2645       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dartpain
Copy link
Contributor

dartpain commented Apr 3, 2024

Good PR, all works well, thank you!

@dartpain dartpain merged commit 3132cc6 into arc53:main Apr 3, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Default document change to empty document
2 participants