Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : add copy button on code snippet #955

Merged
merged 4 commits into from
May 18, 2024

Conversation

sossost
Copy link
Contributor

@sossost sossost commented May 16, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature
  • Why was this change needed? (You can also link to an open issue here)
    [Feature] Copy button on code snippet #950
  • Other information:

Copy link

vercel bot commented May 16, 2024

@sossost is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@sossost sossost changed the title Feat/add copy button on code snippet Feat : add copy button on code snippet May 16, 2024
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:55am

@dartpain
Copy link
Contributor

Hi @sossost
Thank you so much for your PR.
There are a few edits that we need to make before we can merge
CleanShot 2024-05-17 at 11 20 02@2x

  1. The new copy button should only be displayed on code blocks. Not other text blocks too.
  2. The copy button should become visible on hover over the code block itself, not the whole message.

Appreciate your contribution!

@sossost
Copy link
Contributor Author

sossost commented May 18, 2024

@dartpain Oh my mistake. I'm fool Additional work has been done and committed.

@dartpain
Copy link
Contributor

@sossost No worries at all!
Thank you so much!

@dartpain dartpain merged commit 6753b55 into arc53:main May 18, 2024
8 checks passed
@sossost
Copy link
Contributor Author

sossost commented May 18, 2024

@dartpain Thank you too. have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants