Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action not failing if the image is not built due to missing conditions #11

Closed
sandrobonazzola opened this issue Oct 12, 2022 · 2 comments · Fixed by #12 or #15
Closed

action not failing if the image is not built due to missing conditions #11

sandrobonazzola opened this issue Oct 12, 2022 · 2 comments · Fixed by #12 or #15
Assignees
@mfleader
Labels
bug Something isn't working

Comments

@sandrobonazzola
Copy link
Contributor

Describe the bug

arcaflow-plugin-image-builder action is not failing if the image is not built due to missing conditions.

Example 1

2022-10-12T05:43:41Z	info		Missing pyproject.toml
2022-10-12T05:43:42Z	info		Failed requirements check, not building: arcaflow-plugin-template-python latest

As we expect the action to perform a build, it should fail if the build is skipped on failed requirements check
@sandrobonazzola sandrobonazzola added the bug Something isn't working label Oct 12, 2022
@sandrobonazzola sandrobonazzola mentioned this issue Oct 12, 2022
Merged
@sandrobonazzola sandrobonazzola self-assigned this Oct 12, 2022
@sandrobonazzola sandrobonazzola mentioned this issue Oct 12, 2022
Closed
sandrobonazzola added a commit that referenced this issue Oct 12, 2022
@sandrobonazzola
build: return an error if build is not performed (#12)
c3608df 
Fixes #11

Signed-off-by: Sandro Bonazzola <sbonazzo@redhat.com>
@sandrobonazzola
Copy link
Contributor Author

sandrobonazzola commented Oct 12, 2022 •
edited
Loading

Still an issue. Now the error is correctly reported but the builder doesn't fail yet:

2022-10-12T09:43:18Z	info		Using config file:/.carpenter.yaml
2022-10-12T09:43:18Z	info		
2022-10-12T09:43:18Z	info		
2022-10-12T09:43:18Z	info		 not set
2022-10-12T09:43:18Z	info		
2022-10-12T09:43:18Z	info		
2022-10-12T09:43:18Z	info		
2022-10-12T09:43:18Z	info		Dockerfile does not contain copy of arcaflow plugin license
2022-10-12T09:43:18Z	info		Missing pyproject.toml
2022-10-12T09:43:19Z	error		Failed requirements check, not building: arcaflow-plugin-wait latest
2022-10-12T09:43:19Z	error		error in build command (%!w(*errors.errorString=&{failed requirements check, not building: arcaflow-plugin-wait latest}))

@sandrobonazzola
Copy link
Contributor Author

moving to @mfleader it's beyond my go very basic knowledge.

@mfleader mfleader linked a pull request Oct 14, 2022 that will close this issue
Improve Error Handling #15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfleader mfleader

Labels
bug Something isn't working
Projects
No open projects
Arcaflow
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: return an error if build is not performed
Improve Error Handling
2 participants
@sandrobonazzola @mfleader